Attention is currently required from: Christian Walter, Johnny Lin, Morgan Jang, Patrick Rudolph, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85492?usp=email )
Change subject: mb/ocp/tiogapass: Wait for BMC
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/85492/comment/8986361b_86a931a6?usp... :
PS2, Line 60: static const long timeout = 180 * 1000;
I would suggest making this a Kconfig just in case
Is GPP_F4 is purposed as a 'BMC ready' signal or a generic purpose signal in tiogapass? Is the usage of GPP_F4 as 'BMC ready' sign depends on specific version of BMC firmware in tiogapass?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85492?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I925aff1ff1ffd3d7388835e62aad2ba339e52472
Gerrit-Change-Number: 85492
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Sun, 08 Dec 2024 12:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com