Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36184 )
Change subject: arch/acpi.h: Use of typedef for acpi_vfct_image_hdr ......................................................................
Patch Set 1: Code-Review+2
Patch Set 1:
Patch Set 1: Code-Review-1
Why? Using struct directly (some times with const) is well established within coreboot. I can point you hundred of instances. I can't remember a single instance (except vendor code) where a structure is made a typedef.
Thanks for your review and comments!!! I agree with you but after analyzing this file "/coreboot/src/arch/x86/include/arch/acpi.h", since almost all other struct defined in this file has used typedef that is the reason I have tried to provide the same kind of coding style as a base. Also, the typedef would be better for readibility purpose.
After reading the whole file, I have to agree with you, though I don't like the different style from other files. It is however a more recent change, so whoever added it followed standard style instead of following file specific style, thus validating your analysis.