Attention is currently required from: Edward O'Callaghan. Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: hp/z220_series: Convert z220_sff_workstation into variant ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/hp/z220_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/62808/comment/05aecfef_98aa66ea PS1, Line 1: BOARD_HP_Z220_SERIES
BOARD_HP_Z220_SERIES_COMMON
Subjective and not strictly required.
File src/mainboard/hp/z220_series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62808/comment/8477c6e5_37879917 PS1, Line 3: select BOARD_HP_Z220_SERIES
Please do selects only in Kconfig and not in Kconfig.name. See mb/siemens/chili for example.
This only makes sense if there is a "base" board and variants on the base board. In this case there are two distinct mainboards. I don't want to change this. See mb/hp/snb_ivb_laptops for example.
File src/mainboard/hp/z220_series/Makefile.inc:
PS1:
Group the entries by stage: […]
I can reorder what was already there, sure, but I was trying to minimise the diff.