Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44731 )
Change subject: soc/mediatek/mt8192: Limit DRAM calibration frequency count to reduce bootup time ......................................................................
Patch Set 40:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44731/40//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44731/40//COMMIT_MSG@7 PS40, Line 7: soc/mediatek/mt8192: Limit DRAM calibration frequency count to reduce bootup time What datasheet (name, revision) is this from? Why is it a build time option, and not selected by default?
https://review.coreboot.org/c/coreboot/+/44731/40//COMMIT_MSG@8 PS40, Line 8: Please elaborate and give concrete numbers.
https://review.coreboot.org/c/coreboot/+/44731/40/src/soc/mediatek/mt8192/Kc... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/44731/40/src/soc/mediatek/mt8192/Kc... PS40, Line 46: options limit option limits
https://review.coreboot.org/c/coreboot/+/44731/40/src/soc/mediatek/mt8192/Kc... PS40, Line 47: frequency frequencies?
https://review.coreboot.org/c/coreboot/+/44731/40/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/44731/40/src/soc/mediatek/mt8192/dr... PS40, Line 404: This shu no need do calibration
This shu does not need to be calibrated, …