Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36179 )
Change subject: drivers/ipmi: Add IPMI BMC FRB2 watchdog timer support ......................................................................
Patch Set 6:
(6 comments)
Nice. Could you run the new files through `clang-format` please?
https://review.coreboot.org/c/coreboot/+/36179/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36179/6//COMMIT_MSG@13 PS6, Line 13: Tested on OCP Monolake. How?
https://review.coreboot.org/c/coreboot/+/36179/6/src/drivers/ipmi/ipmi_ops.h File src/drivers/ipmi/ipmi_ops.h:
https://review.coreboot.org/c/coreboot/+/36179/6/src/drivers/ipmi/ipmi_ops.h... PS6, Line 48: * Return 0 on success, return 1 on error. Please use CB_SUCCESS and friends.
https://review.coreboot.org/c/coreboot/+/36179/6/src/drivers/ipmi/ipmi_ops.c File src/drivers/ipmi/ipmi_ops.c:
https://review.coreboot.org/c/coreboot/+/36179/6/src/drivers/ipmi/ipmi_ops.c... PS6, Line 21: uint8_t action) The line length is now longer, I believe.
https://review.coreboot.org/c/coreboot/+/36179/6/src/drivers/ipmi/ipmi_ops.c... PS6, Line 50: printk(BIOS_ERR, "IPMI: %s reset wdt command failed (ret=%d resp=0x%x)\n", Please mention the effects of this error.
https://review.coreboot.org/c/coreboot/+/36179/6/src/drivers/ipmi/ipmi_ops.c... PS6, Line 72: printk(BIOS_ERR, "IPMI: %s get wdt command failed (ret=%d resp=0x%x)\n", Please mention the effects in the message.
https://review.coreboot.org/c/coreboot/+/36179/6/src/drivers/ipmi/ipmi_ops.c... PS6, Line 91: printk(BIOS_ERR, "IPMI: %s set wdt command stop timer failed (ret=%d resp=0x%x)\n", Ditto.