Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34157 )
Change subject: soc/intel/cannonlake: Add device Ids for new CFL SKUs support ......................................................................
Patch Set 14:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34157/8/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/34157/8/src/include/device/pci_ids.... PS8, Line 3052: #define PCI_DEVICE_ID_INTEL_CFL_S_GT2x8_DT 0x3e98 : #define PCI_DEVICE_ID_INTEL_CFL_S_GT2x8_WS 0x3e9a
These can be 6+2 too
Done
https://review.coreboot.org/c/coreboot/+/34157/8/src/include/device/pci_ids.... PS8, Line 3117: #define PCI_DEVICE_ID_INTEL_CFL_ID_Sx8_WS 0x3e31
Please realign the whole block (i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/34157/8/src/include/device/pci_ids.... PS8, Line 3219: #define PCH_CNP_H_MOBILE_C246 0xa309
This is not mobile, is it? […]
DT stands for desktop. there are 3 variants: Mobile, DT & WS (workstation)
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo... File src/soc/intel/cannonlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo... PS8, Line 109: 2
Yes, that's what I meant (it's hard to spot but I highlighted the 2 in 6+2 […]
Done
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo... PS8, Line 111: 2
same here
Done
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo... PS8, Line 112: 2
and here
Done
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/common/block/... PS8, Line 4: 2019
This should reflect the year when some creative addition was made, not […]
Done