[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add spmfw loader

[Roger Lu (Code Review)]

Roger Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )

Change subject: soc/mediatek/mt8192: add spmfw loader
......................................................................

Patch Set 36:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/sp... 
File src/soc/mediatek/mt8192/spm.c:

https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/sp... 
PS35, Line 453: if (read32(&mtk_spm->md32pcm_dma0_src) != ptr ||
              : 	    read32(&mtk_spm->md32pcm_dma0_dst) != pmem_start ||
              : 	    read32(&mtk_spm->md32pcm_dma0_wppt) != pmem_words ||
              : 	    read32(&mtk_spm->md32pcm_dma0_wpto) != dmem_start ||
              : 	    read32(&mtk_spm->md32pcm_dma0_count) != total_words ||
              : 	    read32(&mtk_spm->md32pcm_dma0_con) != MD32PCM_DMA0_CON_VAL) {
> If compared to "checking consistency", I'd rather always kick IM to refetch our trusted data. […]

Okay, I see. Let's do "always kick IM to refetch". I'll update it in the next patch.