Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 58:
(49 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/ce594e11_7c5a9948 PS58, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/41aa8a93_549af72a PS58, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/72564759_4394b7e8 PS58, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/9d21afa4_078dfa49 PS58, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/44908346_5b370f3d PS58, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/02ca87c9_1535d106 PS58, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/5b42acef_ab0d9047 PS58, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/daf88808_4f3239d1 PS58, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/622e30d5_961dc1a9 PS58, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/61845c3e_5f1c2b18 PS58, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/2e1c18b1_7f70b303 PS58, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/5716609f_e1083bf8 PS58, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/e96d0c5e_66ffe8e0 PS58, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/89f92a35_b134d36a PS58, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/781b0785_3895ee52 PS58, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/843b5250_b841f9fa PS58, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/24b67538_ff311507 PS58, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/48aa01af_4d1abc0c PS58, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/2724463f_4d49d109 PS58, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/d50f3080_940dfb01 PS58, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/b88bb05a_d99919e0 PS58, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/47327f05_b771dbdc PS58, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/c02c1bf6_7b6538d9 PS58, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/7ba0ca45_b52e7a85 PS58, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/62fb5686_93d01121 PS58, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/63d69826_a3f105b9 PS58, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/203d909d_aa9e976d PS58, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/3e122330_d8865da9 PS58, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/d3e99326_762427f7 PS58, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/b7f9c772_fba26c55 PS58, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/4d6754cb_5bd4fba6 PS58, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/40ecf9c8_480548bd PS58, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/d2735277_c3c703db PS58, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/0c93c969_5bcbdbfb PS58, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/e6d02947_f1dcf0ac PS58, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/1737c63f_712c941e PS58, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/35d15b1d_165612f8 PS58, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/c1e7f189_fa2ea24d PS58, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/424c562b_210db2a7 PS58, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/ddef4161_e99c58a3 PS58, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/e79a0ef6_0bee3361 PS58, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/d5114753_172addb8 PS58, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/47dd3e5c_2b21fe7f PS58, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/bf62cfbd_98072af8 PS58, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/e76000e0_ede79916 PS58, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/379e5383_7c7b9fdd PS58, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/5e1c1b00_b7a6ea86 PS58, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/b7ec7ce5_dbb349f8 PS58, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159868): https://review.coreboot.org/c/coreboot/+/23586/comment/901a5928_4485d963 PS58, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const