[coreboot-gerrit] [M] Change in coreboot[main]: drivers/intel/fsp2_0: Simplify FSP global reset definition

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Paul Menzel, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Tarun, Werner Zeh.

Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84356?usp=email )

Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition
......................................................................

Patch Set 6:

(2 comments)

File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/84356/comment/68e0d6d3_3d2b16cc?usp... :
PS6, Line 347: 3
what is this magic number ?

earlier implementation was much clear, please keep the same implementation.

File src/soc/intel/apollolake/Kconfig:

https://review.coreboot.org/c/coreboot/+/84356/comment/dda330c4_82175bfe?usp... :
PS6, Line 400: 	default 5
no one can follow these magic numbers w/o an explanation. The earlier implementation was very clean. Here you are only planning to add 64-bit support. that can be added like what you did as along as Intel FSP spec explicitly says what is the reset status difference between 32-bit vs 64-bit