Attention is currently required from: Julius Werner, Martin L Roth, Nico Huber.
Martin Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83118?usp=email )
Change subject: Kconfig: Remove prompt for FW_CONFIG_SOURCE_CHROMEEC_CBI
......................................................................
Patch Set 1:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/83118/comment/32c931f5_8e34e7c7?usp... :
PS1, Line 509: bool "Firmware Configuration Probing"
This looks spurious too. […]
Agreed. It might be that these were left with prompts so they can be updated with saved config files instead of being selected in the mainboard's Kconfig, or maybe these are just left over from initial testing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83118?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf170dc2ef790d6f5a897a9c7c2ea64033bf1dc9
Gerrit-Change-Number: 83118
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 21 Jun 2024 20:03:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
