Attention is currently required from: YH Lin, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro, Zhuohao Lee.
Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56889 )
Change subject: mb/google/brya/variants/gimble: Update GPIO for PP1800 DMIC enable
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56889/comment/a34ced7c_23e3e376
PS1, Line 9: PP1800 DMIC
If this is supposed to be PP1800, do you also need to change FIT config to set GPP_D16 to 1. […]
Yes, I have uploaded CL to set GPP_D16 to 1.8V, please help to review it, thanks.
CL : https://chrome-internal-review.googlesource.com/c/chromeos/overlays/baseboar...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56889
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0639162e2c3f02f622470fa16c21fe8a067cf7c
Gerrit-Change-Number: 56889
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 10 Aug 2021 08:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment