Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email )
Change subject: acpi/acpi.c: Don't set MADT lapic addr on !ENV_X86 ......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76070/comment/29879cca_2950f179 : PS1, Line 161: if (ENV_X86)
I'm fine with this, but one might consider moving this and the COMMON_MADT conditionals below over […]
We already have arch_fill_fadt(), I think it has worked out pretty well so perhaps introduce arch_fill_madt() ?
One thing to consider; from somewhere ARM builds needs to pickup cpu_lapic_addr() prototype. I know it's in cpu/cpu.h now but with the discussion here, it soudns like arch/cpu.h or cpu/x86/lapic.h would be more correct. And even XAPIC aka LAPIC MMIO is slowly disappearing, making this entry obsolete.
I think it gets troublesome if we add clearly arch-specific function prototypes to arch-agnostic headers like what I consider <cpu/cpu.h> is. Also, I believe we do not want to unconditionally include from both <arch/x86/> and <arch/arm> in a single file.