Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25345 )
Change subject: soc/amd/stoneyridge: Generate SPCR table
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/25345/6/src/soc/amd/stoneyridge/uart.c
File src/soc/amd/stoneyridge/uart.c:
https://review.coreboot.org/#/c/25345/6/src/soc/amd/stoneyridge/uart.c@41
PS6, Line 41: AMDCZ
Why do we need to use the special IDs? […]
Raul, I'm fine with configuring the baud rate in coreboot and passing a 0 here.
Relevant line from the spec:
The baud rate the BIOS used for redirection.
0 = as is, operating system relies on the current configuration of serial port until the full featured driver will be initialized.
Dan, Does that work for you?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc98bcf4f8c070b8002bcc795254b19f928c741b
Gerrit-Change-Number: 25345
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Mon, 24 Jun 2019 21:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Gerrit-MessageType: comment