Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43294 )
Change subject: mb/google/dedede: Change HDMI DDC gpio to native function ......................................................................
mb/google/dedede: Change HDMI DDC gpio to native function
HDMI DDC gpios were configured as NC till now in wdoo. This may cause HDMI i2c transfer to break and edid read may fail if FSP doesn't configure these gpios properly.
Configuring these gpios as native in coreboot to fix the potential issue.
Change-Id: If02f062132d7c3b01b07ea9401e81f451df35c3c Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/baseboard/gpio.c 1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/43294/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index 71c0c14..d146002 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -215,18 +215,18 @@ PAD_NC(GPP_E11, NONE), /* E12 : GPP_E12/IMGCLKOUT_4 */ PAD_NC(GPP_E12, NONE), - /* E13 : GPP_E13/DDI0_DDC_SCL */ - PAD_NC(GPP_E13, NONE), - /* E14 : GPP_E14/DDI0_DDC_SDA */ - PAD_NC(GPP_E14, NONE), - /* E15 : GPP_E15/DDI1_DDC_SCL */ - PAD_NC(GPP_E15, NONE), - /* E16 : GPP_E16/DDI1_DDC_SDA */ - PAD_NC(GPP_E16, NONE), - /* E17 : HDMI_DDC_SCL */ - PAD_NC(GPP_E17, NONE), - /* E18 : HDMI_DDC_SDA */ - PAD_NC(GPP_E18, NONE), + /* E13: DDI0_DDC_SCL */ + PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1), + /* E14: DDI0_DDC_SDA */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), + /* E15: DDI1_DDC_SCL */ + PAD_CFG_NF(GPP_E15, NONE, DEEP, NF1), + /* E16: DDI1_DDC_SDA */ + PAD_CFG_NF(GPP_E16, NONE, DEEP, NF1), + /* E17: DDI2_DDC_SCL */ + PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), + /* E18: DDI2_DDC_SDA */ + PAD_CFG_NF(GPP_E18, NONE, DEEP, NF1), /* E19 : GPP_E19/IMGCLKOUT_5/PCIE_LNK_DOWN */ PAD_NC(GPP_E19, NONE), /* E20 : CNV_BRI_DT_R */