Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: mb/google/kukui: Introduce a new 'Jacuzzi' family.
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7
PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
I don't understand what Paul means with the 2nd suggestion, but I'd change the "kukui:" at the begin […]
Done
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/...
PS3, Line 21: def_bool n
The only purpose of this option is to guard the ones below, so you shouldn't create a new one for th […]
I'd imagine there'll be much more Jacuzzi's than Kukui, and that's why I created two different common groups.
But as you said, I may try building them with features.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753
Gerrit-Change-Number: 34344
Gerrit-PatchSet: 4
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 16 Jul 2019 02:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment