Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38608 )
Change subject: WIP: Move SA _CRS to runtime SSDT generator ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38608/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/38608/2/src/soc/intel/common/block/... PS2, Line 286: 0x100000 symbolic constant would be nice
https://review.coreboot.org/c/coreboot/+/38608/2/src/soc/intel/common/block/... PS2, Line 291: 0x400 symbolic constant would be nice
https://review.coreboot.org/c/coreboot/+/38608/2/src/soc/intel/common/block/... PS2, Line 366: if (res->base < 1 * MiB) a comment for the reasoning here would be good
https://review.coreboot.org/c/coreboot/+/38608/2/src/soc/intel/common/block/... PS2, Line 402: acpi_fill_ssdt_generator .acpi_fill_ssdt