Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43164 )
Change subject: lib: Update ASan compiler flags and Kconfig help text
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43164/4/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/43164/4/src/Kconfig@284
PS4, Line 284: Before using this feature, make sure that asan_shadow_offset_callback
: patch is applied to GCC.
I'd make this a Kconfig comment that pops up when selecting ASAN. I forgot about it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia187e4991bf808f4ae137eff0ffdb9baea0085e9
Gerrit-Change-Number: 43164
Gerrit-PatchSet: 4
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 24 Jul 2020 14:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment