Martin Roth has posted comments on this change. ( https://review.coreboot.org/21587 )
Change subject: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x220/devicetree... File src/mainboard/lenovo/x220/devicetree.cb:
https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x220/devicetree... PS1, Line 171: 54
maybe change to 14 to avoid confusion with comment?
Maybe just remove it, since it isn't used if bdc detection is disabled?
https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x230/devicetree... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x230/devicetree... PS1, Line 173: register "bdc_gpio_num" = "54" : register "bdc_gpio_lvl" = "0" Remove?