Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38428 )
Change subject: soc/intel/skylake/acpi/dptf/thermal.asl: Prevent iasl remarks
......................................................................
Patch Set 3:
Patch Set 2:
I wonder if there is a solution that would allow using less preprocessor.
I had a look at it. You are right. I updated the code to make it easier to read. Unfortunately, I am not aware of a better way to prevent the remarks. I am not aware of a pragma indicating an argument is optional or not handled on purpose.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38428
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54fa4712e618038fdd5a96c2012c2ec64ca34706
Gerrit-Change-Number: 38428
Gerrit-PatchSet: 3
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 15 Jan 2020 11:14:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment