Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32062 )
Change subject: soc/intel/braswell/smbus: Init SMBus ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32062/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32062/2//COMMIT_MSG@12 PS2, Line 12: Also make Intel southbridge common SMBus API compatible with SPD library.
Suggested change of last line: […]
Done
https://review.coreboot.org/#/c/32062/2/src/soc/intel/braswell/include/soc/s... File src/soc/intel/braswell/include/soc/smbus.h:
https://review.coreboot.org/#/c/32062/2/src/soc/intel/braswell/include/soc/s... PS2, Line 31: #define HOSTC 0x40 : #define HST_EN (1 << 0)
These defines are available in soc\intel\common\block\smbus\smbuslib.h. […]
Did not want to mix Intel SoC common and Intel southbridge common, I thought it could introduce some kind of confusion. But no reason to duplicate defines like that.