Attention is currently required from: YH Lin, Nick Vaccaro, Eric Lai, Wisley Chen, Mark Hsieh, EricR Lai, Felix Held.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62739 )
Change subject: mb/google/brya: set GPP_D0 to GPO and unlocked
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brya/gpio.c:
https://review.coreboot.org/c/coreboot/+/62739/comment/25610018_7ecd1263
PS2, Line 122: /* D1 : ISH_GP1 ==> FP_RST_ODL */
: PAD_CFG_GPO_LOCK(GPP_D1, 1, LOCK_CONFIG),
: /* D2 : ISH_GP2 ==> EN_FP_PWR */
: PAD_CFG_GPO_LOCK(GPP_D2, 1, LOCK_CONFIG),
for redrix (GPP_D1/GPP_D2 in 14505.21.0) […]
Wisley, redrix didn't lock the GPIO setting. https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I164ffff6bd3b4058d6e28247eb7c3ed46d3891b5
Gerrit-Change-Number: 62739
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 14 Mar 2022 08:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-MessageType: comment