Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61724 )
Change subject: console: Add missing va_end() in wrap_interactive_printf() ......................................................................
console: Add missing va_end() in wrap_interactive_printf()
I think this doesn't do anything on most architectures, but it should still be there just in case. Found by Coverity.
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I845a784d90f65610fd1e0d751ea13e9af5b970fd Reviewed-on: https://review.coreboot.org/c/coreboot/+/61724 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/console/printk.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/console/printk.c b/src/console/printk.c index 8db2c45..341c255 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -74,6 +74,7 @@ va_list args; va_start(args, fmt); vtxprintf(console_interactive_tx_byte, fmt, args, NULL); + va_end(args); }
static void line_start(union log_state state)