Attention is currently required from: Bao Zheng, Zheng Bao.
Martin L Roth has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84130?usp=email )
Change subject: amdfwtool: Set the field when the header is created
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
Please just update the commit message before merging.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84130/comment/86a958c2_edd62951?usp... :
PS2, Line 7: the field
Which field?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84130?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I55c400e45536a57841b01d7c90d3fef9afa53e78
Gerrit-Change-Number: 84130
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes