Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
......................................................................
Patch Set 20: Code-Review+1
(2 comments)
File src/soc/mediatek/common/include/soc/mt6363_sdmadc.h:
https://review.coreboot.org/c/coreboot/+/85128/comment/b6729dd4_adfdf870?usp... :
PS20, Line 87: void mt6363_sdmadc_init(void);
remove
File src/soc/mediatek/common/mt6363_sdmadc.c:
https://review.coreboot.org/c/coreboot/+/85128/comment/3774ace9_2fb3744a?usp... :
PS20, Line 78: mt6363_init_pmif_arb();
move to line 76
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a
Gerrit-Change-Number: 85128
Gerrit-PatchSet: 20
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 06 Dec 2024 11:49:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes