Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48188 )
Change subject: soc/amd: factor out SMBUS controller registers into common header ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48188/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/smbus.h:
https://review.coreboot.org/c/coreboot/+/48188/1/src/soc/amd/common/block/in... PS1, Line 14: /* TODO: this one looks odd */
Looking at smbus_wait_until_done(), it looks intentional. […]
ah, yes, that sounds like what's happening there. fixing this would be out of scope for the patch. i'll drop it and add a comment in the code using this why it looks at that bit in a follow-up commit
https://review.coreboot.org/c/coreboot/+/48188/1/src/soc/amd/picasso/southbr... File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/48188/1/src/soc/amd/picasso/southbr... PS1, Line 116: fch_smbus_init
Beyond the scope of this patch, but this might be movable too.
planned to do that as separate follow-up patch yesterday evening, but somehow forgot to do that today