Attention is currently required from: Furquan Shaikh, Martin Roth, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Patrick Rudolph, Karthik Ramasubramanian. Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50472 )
Change subject: elog: Support logging CSE Lite info in elog ......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50472/comment/7c0d74b7_d08101c4 PS6, Line 25: 2 | 2021-01-21 08:46:18 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269 : | YES | 0x5 | 0x3 | RO : 3 | 2021-01-21 08:46:21 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269 : | YES | 0x5 | 0x0 | RW
These two entries can be a bit confusing. […]
To move logging cse lite info in ramstage would require us to move heci command implementations to common cse lib. Also, calling these commands again from ramstage would add additional time overhead. We can think of, 1) Logging the parameters only when CSE boots from RW. 2) To add an additional elog event in cse_board_reset indicating it is a cse initiated global reset. Your thoughts?
https://review.coreboot.org/c/coreboot/+/50472/comment/2592acaa_74076046 PS6, Line 29: 4 | 2021-01-21 08:46:25 | System boot | 3098
Humm.. this is what I was referring to. […]
Can we move "System boot" event log to romstage? or can we have the timeline in this order ? 1. CSE lite info log, booting from RO 2. CSE initiated global reset 3. CSE lite info log, booting from RW 4. System boot