build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46956 )
Change subject: soc/intel/broadwell: Align memmap.h with Haswell ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/has... File src/soc/intel/broadwell/haswell.h:
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/has... PS4, Line 88: #define MCHBAR8(x) *((volatile u8 *)(DEFAULT_MCHBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/has... PS4, Line 89: #define MCHBAR16(x) *((volatile u16 *)(DEFAULT_MCHBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/has... PS4, Line 90: #define MCHBAR32(x) *((volatile u32 *)(DEFAULT_MCHBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/pch... File src/soc/intel/broadwell/pch/rcba.h:
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/pch... PS4, Line 8: #define RCBA8(x) *((volatile u8 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/pch... PS4, Line 9: #define RCBA16(x) *((volatile u16 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46956/4/src/soc/intel/broadwell/pch... PS4, Line 10: #define RCBA32(x) *((volatile u32 *)(DEFAULT_RCBA + x)) Macros with complex values should be enclosed in parentheses