13 Aug
2020
13 Aug
'20
8:22 a.m.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44430 )
Change subject: cse_lite: Move global reset after MRC writeback. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44430/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/44430/1/src/soc/intel/common/block/... PS1, Line 657: #if CONFIG(SOC_INTEL_TIGERLAKE)
It would be helpful to have a comment here explaining why this particular phase was chosen for Tiger […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/44430
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia42d72fdec41f9792ab8f04205b20a55758a4235
Gerrit-Change-Number: 44430
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 13 Aug 2020 08:22:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment