Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31308 )
Change subject: src/mainboard/emulation/Kconfig: disable DRIVERS_INTEL_WIFI by default ......................................................................
Patch Set 3:
(3 comments)
What does this fix?
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG@7 PS3, Line 7: src/mainboard/emulation/Kconfig: disable DRIVERS_INTEL_WIFI by default This is much too long. The src/ and /Kconfig can be droped without really losing information.
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG@11 PS3, Line 11: should work fine. So this driver option is not required and could be disabled. It doesn't matter if it is physical. The driver in question is 95% *not* about initialization, so this reasoning seems pointless.
Please adhere to the 72 chars line limit.
https://review.coreboot.org/#/c/31308/3/src/mainboard/emulation/Kconfig File src/mainboard/emulation/Kconfig:
https://review.coreboot.org/#/c/31308/3/src/mainboard/emulation/Kconfig@24 PS3, Line 24: default n If I'd see this (without this change in mind), I'd probably want to clean it up. So better provide a reasoning here why we need the clutter. e.g. optimization of the flash chip usage to the last emulated byte. oh, wait, looks like I didn't understand the reason.