Attention is currently required from: Subrata Banik, Angel Pons, Kyösti Mälkki, Elyes Haouas.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72488 )
Change subject: cpu,soc/intel: Use acpigen_write_processor_device()
......................................................................
Patch Set 9: Code-Review+2
(2 comments)
File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/c/coreboot/+/72488/comment/f9e64fdf_1332a6d8
PS4, Line 80: int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;
the i/o port based c state entry can also be done with acpigen_write_processor_device, so you can re […]
the part this was about was taken out of the patch, so i'll mark this as resolved
File src/southbridge/intel/i82371eb/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/72488/comment/da808252_6860034a
PS3, Line 31: acpigen_write_processor_device(cpu);
in that case, the processor objects are defined in the dsdt and without having looked at the code i' […]
this part was taken out of the patch, so i'll mark this as resolved
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72488
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1448e0a8845b3a1beee0a3ed744358944faf66d8
Gerrit-Change-Number: 72488
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 14 Apr 2023 12:28:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment