Attention is currently required from: Christian Walter, Julius Werner, Jérémy Compostella, Krystian Hebel, Martin L Roth, Michał Żygowski.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159?usp=email )
Change subject: security/tpm: make tis_probe() return tpm_family ......................................................................
Patch Set 25:
(6 comments)
File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/c322525c_add6e2f1 : PS24, Line 58: *family = TPM_2;
See CB:80454 […]
Done. My personal preference is to not hide such invocation mistakes because this leads to code working when it actually shouldn't.
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/947cf202_078dcb4f : PS24, Line 430: *family = TPM_2;
a/a
Done
File src/drivers/i2c/tpm/tis_atmel.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/b2f3b014_4c2f9155 : PS24, Line 121: *family = CONFIG(TPM1) ? TPM_1 : TPM_2;
a/a
Done
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/89366646_66f2b2d5 : PS24, Line 474: *family = CONFIG(TPM1) ? TPM_1 : TPM_2;
a/a
Done
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/04847d12_3e06c434 : PS24, Line 389: return TPM_SUCCESS; /* Already probed. */
Here you have to return the family, otherwise `*family` checks will fail if pc80_tis_probe is called […]
Done
File src/drivers/spi/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/87611016_28bb9836 : PS24, Line 60: *family = TPM_2;
a/a
Done