Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85717?usp=email )
Change subject: mb/google/rauru: Add support for getting storage id ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85717/comment/aaa92057_9341ddd1?usp... : PS1, Line 14: SKU IDs Storage ID
https://review.coreboot.org/c/coreboot/+/85717/comment/a8f5bcd7_12c5d19f?usp... : PS1, Line 61: printk(BIOS_DEBUG, "Storage ID: %#02x\n", cached_panel_id); insert the blank line on above
https://review.coreboot.org/c/coreboot/+/85717/comment/8963a858_88e8ad81?usp... : PS1, Line 62: remove this blank line
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85717/comment/59599bd4_251d14ef?usp... : PS1, Line 14: #include <soc/mt6363_sdmadc.h> remove ?
https://review.coreboot.org/c/coreboot/+/85717/comment/37da7354_bb4a8726?usp... : PS1, Line 63: mt6363_get_vtref18_voltage(); Remove `mt6363_get_vtref18_voltage`. It is not needed.
https://review.coreboot.org/c/coreboot/+/85717/comment/c331e64d_01309fbb?usp... : PS1, Line 60: mt6363_init_pmif_arb(); : mt6363_enable_vtref18(true); : mt6363_set_vtref18_voltage(1800000); : mt6363_get_vtref18_voltage(); Move to `romstage`. We will determine _PCIe initialization_ (for NVMe storage) by `storage_id` right after jumping into `ramstage` (in `enable_soc_dev()`).
It will be too late to power on `vtref18`.