Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42675 )
Change subject: util/mb/google/tmpl/puff: Import overridetree.cb copy
......................................................................
Patch Set 1: Code-Review+2
That seems like a really large overridetree.cb.
My CR+2 assumes that there isn't a clean way to have most of that in puff and then have the variants just override little bits from puff instead of hatch. Similar to how ec.h now includes puff/ec.h instead of baseboard/ec.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40faa5f80e78cd73ba5ef977574f7f662c0ab8a1
Gerrit-Change-Number: 42675
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 23:49:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment