Attention is currently required from: Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )
Change subject: soc/mediatek/mt8196: Add EINT support
......................................................................
Patch Set 8:
(1 comment)
File src/soc/mediatek/mt8196/eint.c:
https://review.coreboot.org/c/coreboot/+/84026/comment/4196227d_117e768d?usp... :
PS8, Line 11: [4]
Use a struct: […]
The original struct is designed for kernel driver.
We can drop `eint_num` and `debounce` because we don't use them in FW. I prefer using `uint8_t` to save `instance` and `index` for smaller code size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84026?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibeb2dafcd9909b4afbfa81728700718f01d3818f
Gerrit-Change-Number: 84026
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 28 Aug 2024 06:41:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com