Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83493?usp=email )
Change subject: mb/google/brya: Standardize TPM TIS ACPI interrupt configuration ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83493/comment/e10bdfb5_aa0cd2ea?usp... : PS1, Line 19: TEST=Builds successfully for all brya boards.
Any changes with timeless build?
Acknowledged
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/83493/comment/a2597145_c0afb51e?usp... : PS1, Line 787:
I would have thought, such configuration would happen in devicetree.
not necessary, TPM_TIS_ACPI_INTERRUPT
https://review.coreboot.org/c/coreboot/+/83493/comment/abaa9ce9_7bf8ead4?usp... : PS1, Line 787:
I would have thought, such configuration would happen in devicetree.
not necessary, TPM_TIS_ACPI_INTERRUPT is a config inside tpm_tis.c code hence, we are only overriding it using mainboard Kconfig file.