Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41247 )
Change subject: soc/amd/common/block/lpc: Split lpc_set_spibase() into two functions
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41247/4/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/41247/4/src/soc/amd/common/block/in...
PS4, Line 186: * eSPI base = SPI base + 0x10000
Just to show the relation between SPI and eSPI MMIO base.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f270ba1745b4bb8a403f00cd069a02e21d444be
Gerrit-Change-Number: 41247
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 May 2020 18:59:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Eric Peers
epeers@google.com
Gerrit-MessageType: comment