Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82704?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: util/cbfstool: Fix linux_trampoline.c generation ......................................................................
util/cbfstool: Fix linux_trampoline.c generation
linux_trampoline.c generation is broken with latest crossgcc-i386 toolchain. Fix the issue to enable the building.
../cbfstool/linux_trampoline.S: Assembler messages: ../cbfstool/linux_trampoline.S:100: Error: no instruction mnemonic suffix given and no register operands; can't size instruction <builtin>: recipe for target '../cbfstool/linux_trampoline.o' failed
TEST=Build and boot on intel/archercity CRB
cd util/cbfstool/ rm linux_trampoline.c make linux_trampoline.c
Change-Id: I7faca296f946bb4e9fd510661357925e5dcf9a6b Signed-off-by: Shuo Liu shuo.liu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/82704 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/cbfstool/linux_trampoline.S 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Angel Pons: Looks good to me, approved build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/util/cbfstool/linux_trampoline.S b/util/cbfstool/linux_trampoline.S index 6a62ff0..4f61209 100644 --- a/util/cbfstool/linux_trampoline.S +++ b/util/cbfstool/linux_trampoline.S @@ -97,7 +97,7 @@ cmp $12, 16(%edi) /* type */ jng .next_e820_entry /* Fixup the type to 2, reserved memory */ -mov $2, 16(%edi) +movl $2, 16(%edi) .next_e820_entry: dec %eax add $20, %edi