17 Nov
2020
17 Nov
'20
12:34 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47381 )
Change subject: drivers/analogix: add MIPI rx flow ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47381/5/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/47381/5/src/drivers/analogix/anx762... PS5, Line 819: mdelay(200); 200/600ms "from test results" does not sound reasonable - will this be different when we have other SOCs, or other panels? Can you check with Analogic to figure out how the numbers should be decided, and document/comment that here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/47381
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6123a030dafb74b9da4e4a56adce3b5a0360d315
Gerrit-Change-Number: 47381
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi jitao.shi@mediatek.com
Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-CC: Jitao Shi jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: Will Lee wwlee@google.com
Gerrit-Comment-Date: Tue, 17 Nov 2020 08:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment