[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add tracker driver

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Paul Menzel, Xiwen Shao, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )

Change subject: soc/mediatek/mt8196: Add tracker driver
......................................................................

Patch Set 20:

(7 comments)

File src/soc/mediatek/mt8196/bootblock.c:

https://review.coreboot.org/c/coreboot/+/84929/comment/6c35dcc1_1e4fed4c?usp... :
PS12, Line 8: tracker_common
> tracker. […]

Done

File src/soc/mediatek/mt8196/include/soc/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/84929/comment/f4fe0b83_97383de0?usp... :
PS12, Line 49: 78K)
> The change is probably no longer needed.

Done

File src/soc/mediatek/mt8196/include/soc/tracker.h:

https://review.coreboot.org/c/coreboot/+/84929/comment/b372c37d_c1727a67?usp... :
PS14, Line 19:
> Remove extra blank line.

Done

File src/soc/mediatek/mt8196/include/soc/tracker.h:

https://review.coreboot.org/c/coreboot/+/84929/comment/f86bef37_e344bd8f?usp... :
PS12, Line 5:
> #include <soc/tracker_common. […]

Done

File src/soc/mediatek/mt8196/tracker.c:

https://review.coreboot.org/c/coreboot/+/84929/comment/2c6ef72f_e2e6cfc2?usp... :
PS12, Line 8: #include <soc/tracker_common.h>
> remove

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/0d9f661c_991e21ce?usp... :
PS12, Line 71: (
> parentheses is not needed.

Done

File src/soc/mediatek/mt8196/tracker.c:

https://review.coreboot.org/c/coreboot/+/84929/comment/e7c9a728_d2fb45eb?usp... :
PS14, Line 27: 	AW_TRACK_L_OFFSET, AW_TRACK_H_OFFSET
> Adding a trailing `,`

Done