Attention is currently required from: Christian Walter, Felix Held.
Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83122?usp=email )
Change subject: Makefile: Update symlink target ......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/coreboot/+/83122/comment/d0ef5636_a54953b3?usp... : PS3, Line 494: symlink: To help review, let me explain what's going on below.
495 - 498: If there are no link files in the variable, populated earlier, exit.
500 - 519: Loop through all of the link files 501: Get the contents of the link file. This says where we're linking to. 502: Get the path of the link file. This is where we're linking from. 503 - 506: If the link already exists, go to the next link file. 507: Change the relative path of the link-to location to an absolute path. 508 - 511: Make sure the link-to location is inside the coreboot repo by removing the path of the coreboot repo from the link-to location. If it doesn't change, it's outside of the repo. Go to next link file. 512 - 518: See if the link-to location exists as something other than a link. If it doesn't, create the link. If that fails, print a warning (This should be unusual.) If the link-to location does already exist, print a warning.