Attention is currently required from: Saurabh Mishra, Paul Menzel.
Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69107 )
Change subject: vc/intel/fsp: Update JSL FSP headers from v2385.04 to v4155.00 ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69107/comment/32c2997c_d8e42a88 PS3, Line 7: vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/69107/comment/d73e3caa_5be06d6d PS3, Line 10: Previous FSP version was v2385.04
- Please add a dot/period at the end of sentences. […]
Done
https://review.coreboot.org/c/coreboot/+/69107/comment/0cae6aef_ac06266a PS3, Line 11: Include
include
Done
https://review.coreboot.org/c/coreboot/+/69107/comment/34e7735e_2849555a PS3, Line 11: Changes Include:
Please add a blank line above.
Done
https://review.coreboot.org/c/coreboot/+/69107/comment/29ed39c1_8bf0db65 PS3, Line 12: FspsUpd.h: Change in header offset. : {FspmUpd.h,FspUpd.h}: Copyright year update. : MemInfoHob.h: Add HOB_GUID_TYPE, HOB_GENERIC_HEADER Struct.
Plesae format this as a list.
Done
https://review.coreboot.org/c/coreboot/+/69107/comment/3bb544b9_44db402a PS3, Line 15:
Please add a note, why the big version jump 2385 to 4155 only has such a few changes.
Hi Paul, FSP Headers changes are pushed for IPU based JSL FSP i.e. FSP v4155.00. There has been a 8Bytes of addition in FSPS Struct.