Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42782 )
Change subject: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/...
PS1, Line 62: Ethernet
It's an Ethernet MAC and for connecting to things, you typically need some sort of external PHY. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17
Gerrit-Change-Number: 42782
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jun 2020 16:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment