Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )
Change subject: src: Use standard <inttypes.h> ......................................................................
Patch Set 7: Code-Review+1
(3 comments)
The idea came up that if the above assumptions are true for all our arch's, we could have a single `stdint.h`. Thoughts?
I we can make that work across all platforms (sounds like we can?) I think it's a good idea.
https://review.coreboot.org/#/c/33823/7/src/include/inttypes.h File src/include/inttypes.h:
https://review.coreboot.org/#/c/33823/7/src/include/inttypes.h@60 PS7, Line 60: j "j" is not supported by our vtxprintf(). Either we have to add it there, or replace all "j" in here with "ll".
https://review.coreboot.org/#/c/33823/7/src/include/inttypes.h@154 PS7, Line 154: /* fscanf macros for signed integers */ There's no fscanf() in coreboot, so we don't really need any of the SCN (although they don't hurt either).
https://review.coreboot.org/#/c/33823/7/src/include/inttypes.h@246 PS7, Line 246: typedef struct { I don't think we need anything below here, so should remove it.