[coreboot-gerrit] Change in coreboot[master]: mb/google/guybrush: Add PSP_S0I3_RESUME_VERSTAGE Kconfig option

[Nico Huber (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60024 )

Change subject: mb/google/guybrush: Add PSP_S0I3_RESUME_VERSTAGE Kconfig option
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> bootblock is not running during s0i3 resume, just verstage.

I meant generally we wouldn't do such init in verstage because the
bootblock would run first (generally in coreboot, i.e. not AMD Zen).
> On AMD, S0i3 is only entered after explicit request from Kernel. The kernel needs to send a shutdown command to the TPM before reset is asserted so the TPM state can be preserved and restored.

Quite interesting. I had a quick look at the TPM spec and, OMG, they
really like to make things look creepy. Now I wonder how it's ensured
that the PCR values are _not_ restored on a normal boot. But that's
nothing I intended to bug you with.

Thanks for the answers :)