23 Oct
2022
23 Oct
'22
2:47 a.m.
Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68596 )
Change subject: payloads/edk2: Set the correct serial settings for AMD SOCs ......................................................................
Patch Set 1:
(2 comments)
File payloads/external/edk2/Makefile:
https://review.coreboot.org/c/coreboot/+/68596/comment/68236ea7_fddc9c10 PS1, Line 103: CONFIG_SOC_AMD_COMMON there's a handful of pre-Zen platforms that select this Kconfig, do they use MMIO for serial as well?
https://review.coreboot.org/c/coreboot/+/68596/comment/34e9152b_8368a042 PS1, Line 105: 0xfedc9000 should probably pass this in as a Kconfig
--
To view, visit https://review.coreboot.org/c/coreboot/+/68596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70630d21bbdb21f2aa8cbaeb3e842629b97af3ba
Gerrit-Change-Number: 68596
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 23 Oct 2022 00:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment