Attention is currently required from: David Wu, Sheng-Liang Pan.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83779?usp=email )
Change subject: mb/google/brox/var/jubilant: Add P-sensor SX9324
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
File src/mainboard/google/brox/variants/jubilant/gpio.c:
https://review.coreboot.org/c/coreboot/+/83779/comment/113fb30a_a45d74e4?usp... :
PS4, Line 37: =======
`spaces required around that '==' (ctx:OxO)`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83779?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I629117f20ca513dc0c8eaa91744ad33e162ba4bb
Gerrit-Change-Number: 83779
Gerrit-PatchSet: 6
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Aug 2024 10:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No