Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81863?usp=email )
Change subject: acpigen_ps2_keybd: Add support for dictation key ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81863/comment/64aefba5_19b1b253 : PS2, Line 14: Flash DUT that emits a scancode for a dictation key, verify that it : is mapped to KEY_DICTATE in the Linux kernel.
Next time, it’d be great if you also documented your comments, so it’s easier for people to reproduc […]
ACK, will do. Yes, I used `evtest` to verify.
File src/acpi/acpigen_ps2_keybd.c:
https://review.coreboot.org/c/coreboot/+/81863/comment/22d7f73b_5b0dd32b : PS2, Line 59: [PS2_KEY_DICTATE] = KEYMAP(0xa7, KEY_DICTATE), /* e027*/
Please sort the entry.
Could you be a bit more specific as to what it should have been sorted by? This table is currently sorted by the enum values.