Attention is currently required from: Yidi Lin.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78888?usp=email )
Change subject: libpayload/libc/time: Fix possible overflow in multiplication
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78888/comment/2b6cbc42_ffbce9d7 :
PS11, Line 15: counter should never be that fast.
Sorry, forgot to mention, Paul ran into the assertion.
Oh okay, yeah, then we need to do something. Which platform did he see it on?
The quickest solution would probably to just switch it back to 64-bit and implement a `gcd64()`... I think we only made it 32 for efficiency because we thought it wouldn't make a difference.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia55532490651fcf47128b83a8554751f050bcc89
Gerrit-Change-Number: 78888
Gerrit-PatchSet: 11
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 06 Feb 2024 20:55:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment