[coreboot-gerrit] Change in coreboot[master]: nb/intel/common: Introduce common MCHBAR accessor functions

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )

Change subject: nb/intel/common: Introduce common MCHBAR accessor functions
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45517/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45517/2//COMMIT_MSG@7 
PS2, Line 7: nb/intel/pineview: Use new mchbar{8,16,32}_and_or()
           : 
           : This fix the overflow error we have with MCHBARx_AND_OR macros:
> These two statements seem not related. Switching from macros to […]

Done

https://review.coreboot.org/c/coreboot/+/45517/2/src/northbridge/intel/pinev... 
File src/northbridge/intel/pineview/raminit.c:

https://review.coreboot.org/c/coreboot/+/45517/2/src/northbridge/intel/pinev... 
PS2, Line 620: (u16)
> yes as "~(1 << 8)" is not an u16.

Done