Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81960/comment/1160f3e9_261921ef : PS1, Line 15: transition. Why would there be such issues? wouldn't libpayload be responsible to switch to long mode properly? The payload (depthcharge) should be only C code, isn't it?
File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/81960/comment/9a1d0092_595ed63d : PS1, Line 25: if (CONFIG(PAYLOAD_X86_64_SUPPORT)) { AIUI, the payload handover and the coreboot tables are the most important ABI pieces of coreboot. Making this a compile-time option would mean that the resulting coreboot is suddenly incompatible to all prior (x86) payload builds. So, shouldn't this be decided at runtime, maybe based on information from CBFS?